[libremkchroot] doesn't always umount when exiting with error
For example, I failed my previous command for libremkchroot, and I tried it a second time with the correct arguments, but it wanted to overwrite the mounted system, reporting errors.
Also, I didn't understand what was happening and I tried to remove the jail directory, without checking that my system was mounted in that directory!
It would be a good and simple behavour to unmount if reporting error.
Updated by lukeshu over 6 years ago
I re-did how signals are handled while the umount function is running. Now I think the only reason it might not umount them is if they were mounted prior to entering the chroot (left by a previous, buggy, version of the script, perhaps?).
I'm marking this at 50%, and will monitor their behavior for a while. If I don't see the scripts leaving mounts as we get closer to releasing "don't break and confuse parabolers", I'll close this.