Project

General

Profile

Bug #2803

Add patch from eschwartz to use system libs in iceweasel / icecat / icedove

GNUtoo - 25 days ago - . Updated 24 days ago.

Status:
confirmed
Priority:
feature
Assignee:
% Done:

0%


Files

History

#1

Updated by GNUtoo 25 days ago

From IRC:

< eschwartz> https://paste.xinu.at/7Xgot73BQ/

We could keep the authorship, like the other patches from Eli Schwartz that are already in abslibre.

#2

Updated by bill-auger 25 days ago

you based that diff on an outdated PKGBUILD (v75) - for the
current build (v76), oaken-source removed the icu dependency
entirely, defaulting to the mozilla vendored icu - the current
PKGBUILD does not have the sqlite dependency either

there is a PKGBUILD for v77 on the mailing list; so further
changes should be base on that

https://lists.parabola.nu/pipermail/dev/2020-June/007803.html

if we are going to use the system icu, then o/c we want to
switch to the sodeps - so the concern to discuss is "do we want
to use the system icu?"

#3

Updated by bill-auger 25 days ago

the current PKGBUILD does not have the sqlite dependency either

there is a PKGBUILD for v77 on the mailing list; so further
changes should be base on that

#5

Updated by bill-auger 25 days ago

bill-auger wrote:

so the concern to discuss is "do we want to use the system icu?"

to answer my own question, i think that generally we (and most distro maintainers) want to prefer system libs - i had to remove --use-system-lib=libvpx recently, because several consecutive releases would not compile with the arch system libvpx

it is a general problem for us, with mozilla things, that the releases seem to target the current state of ubuntu, and routinely fail in multiple ways if the build envoronment has too much delta from a ubuntu system - our version of rust is often not able to build them either

#6

Updated by eschwartz 24 days ago

Mozilla upstream stopped supporting a system sqlite at all, see https://bugzilla.mozilla.org/show_bug.cgi?id=1611386
So that belongs removed.

libvpx was fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=1525393 and should therefore work fine on current versions of Firefox and derivatives. If it ever breaks again, I recommend commenting out the ac_add_options rather than removing it, so it can be reconsidered for inclusion once it works again...

#7

Updated by bill-auger 24 days ago

yea i could have been more clear about that - IIRC, "I" did only
comment it out - it was like that for a long time - someone else
deleted it after i explained how long it had been, since it was
usable

grizzlyuser offered a new PKGBUILD a few days ago - oaken-source
has declared himself as watcher of the mailing list patches - if
grizzlyuser and he is going to do the work, im not going to
complain too loudly about how they do it - OTOH, if oaken-source
does not do it before beefcake comes back online, i will try
building the next version with the system icu and libvpx

oaken-source may not even see this discussion - patches and
discussions of this sort are generally better on the mailing
list - it may be only freemor and myself who are subscribed
to every redmine activity

Also available in: Atom PDF