Project

General

Profile

Bug #378

[libremakepkg] reintroduce -u

mtjm - about 7 years ago - . Updated over 6 years ago.

Status:
not-a-bug
Priority:
feature
Category:
-
Assignee:
% Done:

0%


Description

It's needed for fullpkg and mips64el builds depending on previously built updates.

HOOKPREBUILD doesn't solve it: it's run only by treepkg, not fullpkg nor libremakepkg; it would run before cleaning the chroot: updating also packages that will be removed before build.

Why not change it for fullpkg only: libremakepkg -u is faster and can be used for toolchain updates and other builds where the dependency tree of fullpkg is wrong (updating packages to the ones built is needed for toolchain updates).

(Not commenting on the issue of it being default/required or a recommended option disabling which can make broken packages.)

History

#2

Updated by lukeshu about 7 years ago

HOOKPREBUILD doesn't solve it: it's run only by ... not fullpkg

Then that should be a feature request in fullpkg. (Here you go: https://labs.parabola.nu/issues/403)

updating also packages that will be removed before build.

Then run `librechroot clean-pkgs` before running `librechroot update`.

(Not commenting on the issue of it being default/required or a recommended option disabling which can make broken packages.)

I think it's not unreasonable to require packagers to update their chroot when it needs to be.


Why I don't want to add this back in: fullpkg/treepkg are actually a good example of why this shouldn't be added. You don't want to run -Syu before every package is built. You run it once at the beginning. Perhaps fullpkg/treepkg should do that for you.

A feature that I would be welcome to implementing is warning if there are uninstalled updates, what do you think?

#3

Updated by mtjm about 7 years ago

"[W]arning if there are uninstalled updates" requires pacman -Sy, so it wouldn't be much different than -Syu with no packages to update? I don't see any other reason to not do it than that it might be slower. Or are there any additional correctness issues when updates are done?

Running two more commands is ok for me, documenting this for mips64el development might be ok too.

#4

Updated by lukeshu about 7 years ago

"[W]arning if there are uninstalled updates" requires pacman -Sy, so it wouldn't be much different than -Syu with no packages to update?

Hmm, that's true.

I... don't know. I feel like updates should have to be an explicit thing (especially with rolling release).

I know most people don't use the "sync" feature, but if you do, the correct thing to do is

librechroot -l root update
librechroot sync

Which is a lot more overhead, so I'd rule out doing that every time.

That brings up the topic: do we really want the "sync" feature? It's inherited from Arch's devtools. I think it could be very useful, and the real benefits would be apparent in automated builds; I think even fullpkg/treepkg could benefit from it by allowing parallel builds.

#5

Updated by lukeshu almost 7 years ago

FWIW, since fixing #437, it doesn't run `pacman -Sy` during chcleanup.

#6

Updated by lukeshu over 6 years ago

  • Status changed from open to not-a-bug

Also available in: Atom PDF