Bug #3622
upstream change in makepkg breaks librefetch
0%
Description
makepkg has introduced a change in this upstream commit:
https://gitlab.archlinux.org/pacman/pacman/-/commit/9af4033cadbdbf528be9c9b78d9ddf6d0102e2d3
that renames the LIBRARY variable to MAKEPKG_LIBRARY.
This change breaks librefetch, because we rely on the name of this variable to produce a modified makepkg here:
https://git.parabola.nu/packages/libretools.git/tree/src/librefetch/librefetchdir/Makefile#n28
History
Updated by bill-auger about 1 month ago
i can not reproduce this
which libretools version/init/arch?
does every PKGBUILD fail for you?
can you show a PKGBUILD which exhibits this behavior?
Updated by oaken-source 30 days ago
this was on my modified icedove PKGBUILD. maybe it only happens on a split package? let me run some tests.
Updated by bill-auger 30 days ago
libretools has a complete test suite - try to make a .bats test which exposes the bug
$ # pacman -S bats $ SUDO_USER= make check TESTENVFLAGS='--no-network --no-sudo'
or:
$ cd test/ # $ testenv --no-network --no-sudo cases/*.bats # $ testenv --no-network --no-sudo cases/specific.bats
Updated by bill-auger 30 days ago
would this be sufficient, for a transitional period?
-old_library := $(shell $(shell grep LIBRARY= $(old_makepkg)); echo $$LIBRARY)
+old_library := $(shell $(shell grep -E '^(MAKEPKG_|)LIBRARY=' $(old_makepkg)) ; \
+ printf $${MAKEPKG_LIBRARY:-$$LIBRARY} ) # BASH
+ [ -n $$MAKEPKG_LIBRARY ] && printf $$MAKEPKG_LIBRARY || printf $$LIBRARY) # portable:
Updated by lukeshu 28 days ago
- Status changed from unconfirmed to fixed
Should be fixed in v20240403 https://git.parabola.nu/packages/libretools.git/commit/?id=6b9ebf370bd1f146b4aa4cd035a6c4d53d588895
Feel free to re-open this if you still have issues.