Project

General

Profile

Bug #2668

[icedove] Update branding files

pks40 - 3 months ago - . Updated 8 days ago.

Status:
in progress
Priority:
bug
Assignee:
% Done:

50%


Description

The branding files for Icedove are missing an entry:

History

#1

Updated by pks40 3 months ago

The branding files for Icedove are missing an entry: In icedove-68.2/icedove-branding/locales/en-US/brand.dtd, an additional line

<!ENTITY  brandProductName      "Icedove">

needs to be added (compare thunderbird-68.2.2/comm/mail/branding/thunderbird/locales/en-US/brand.dtd).

I can confirm that the brandProductName is used in the "Profile Downgrade" message window: that's where I encountered a problem -- the window didn't show up, instead there was an error message.
At the moment, it doesn't seem to be used in any other important place, thus I don't categorise this as a bug. Nevertheless it would be nice if this issue could be fixed.

The brandProductName line should also be added to all language packs for Icedove (even though that is not needed for the Profile Downgrade window).

Maybe we should also add a brand.ftl file (see the Thunderbird source), even though I have no idea if and where it is used.

#2

Updated by oaken-source 3 months ago

  • % Done changed from 0 to 50
  • Assignee set to oaken-source
  • Status changed from open to in progress
  • Tracker changed from Packaging request to Bug

thanks for the report. this should be fixed in icedove-68.6.

I'll look into fixing this for the langpacks as well.

#3

Updated by pks40 3 months ago

Thanks a lot! This also seems to be relevant for Iceweasel, see #2571.

#4

Updated by bill-auger 3 months ago

is this fixed? - can the ticket be closed?

#5

Updated by oaken-source 3 months ago

yes, this should be fixed in 68.6, I'm leaving it open as of now, because the langpacks could still be affected. I need to check.

#6

Updated by bill-auger 8 days ago

oaken-source - can the ticket be closed now?

Also available in: Atom PDF