Bug #347
[librerelease] pinentry-curses breaks terminal
100%
Description
if you are using gnupg2 with pinentry-curses for password input, when using librerelease without a cached password, terminal output breaks because of the usage of `read` in the find packages | while read { sign }.
usually i solve this by using `for package in $(find packages)`, that doesn't capture user input, but i tried this and it also breaks the output (!).
librerelease should also fail if the sign_packages function doesn't exit succesfully, since it leads to uploading unsigned packages, failed db-update server-side and having to librestage all over again. i'm pushing a fix for this.
History
Updated by lukeshu almost 11 years ago
I fixed this in the last release. https://projects.parabolagnulinux.org/packages/libretools.git/commit/?id=ad49ac2698b331a94b97dbad6d68c85bff8fa94a
usually i solve this by using `for package in $(find packages)`,
that doesn't capture user input, but i tried this and it also breaks
the output (!).
That's odd, because that's the fix I used, and it worked fine when I tested it. Perhaps you are accidentally testing against an old version?
Updated by fauno over 10 years ago
I've emailed you three patches fixing this issue by signing a file to cache the passphrase, outside the loop
Updated by lukeshu almost 10 years ago
- Status changed from in progress to fixed
- Assignee set to lukeshu
Confirmed that this is fixed in current versions.