Project

General

Profile

Bug #347

[librerelease] pinentry-curses breaks terminal

fauno - almost 11 years ago - . Updated over 5 years ago.

Status:
fixed
Priority:
bug
Category:
-
Assignee:
% Done:

100%


Description

if you are using gnupg2 with pinentry-curses for password input, when using librerelease without a cached password, terminal output breaks because of the usage of `read` in the find packages | while read { sign }.

usually i solve this by using `for package in $(find packages)`, that doesn't capture user input, but i tried this and it also breaks the output (!).

librerelease should also fail if the sign_packages function doesn't exit succesfully, since it leads to uploading unsigned packages, failed db-update server-side and having to librestage all over again. i'm pushing a fix for this.

History

#2

Updated by fauno almost 11 years ago

8fb79bc contains the fix i mentioned

#3

Updated by lukeshu almost 11 years ago

I fixed this in the last release. https://projects.parabolagnulinux.org/packages/libretools.git/commit/?id=ad49ac2698b331a94b97dbad6d68c85bff8fa94a

usually i solve this by using `for package in $(find packages)`,
that doesn't capture user input, but i tried this and it also breaks
the output (!).

That's odd, because that's the fix I used, and it worked fine when I tested it. Perhaps you are accidentally testing against an old version?

#4

Updated by fauno over 10 years ago

I've emailed you three patches fixing this issue by signing a file to cache the passphrase, outside the loop

#5

Updated by lukeshu almost 10 years ago

  • Status changed from in progress to fixed
  • Assignee set to lukeshu

Confirmed that this is fixed in current versions.

#6

Updated by marthasimons over 5 years ago

very interesting,i have similar bag

#7

Updated by marthasimons over 5 years ago

  • File 321c.gz added
#8

Updated by bill-auger about 5 years ago

  • File deleted (321c.gz)

Also available in: Atom PDF